Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ujson dependency #26

Open
tamedfox42 opened this issue Jul 25, 2023 · 1 comment
Open

Update ujson dependency #26

tamedfox42 opened this issue Jul 25, 2023 · 1 comment

Comments

@tamedfox42
Copy link

Hello,

within a Pretix deployment in our team, we had issues with incompatible versions of ujson and drf_ujson.

This library (drf_ujson2) uses the default parameter from ujson in renderers.py#L44. This parameter is introduced in version 4.2.0 of ujson. However, drf_ujson2 only enforces ujson>=2.0.1 as dependency.

From my point of view, we should change this dependency to at least ujson>=4.2.0. Are there any objections against this proposal?
@Amertz08
Copy link
Owner

Thanks for bringing this up. I will dig into the changes and see what needs to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amertz08 @tamedfox42