Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
hanby-choi
approved these changes
Mar 20, 2024
| } | ||
|
|
||
| for(int i=0; i<n-1; i++){ | ||
| cin >> temp; |
There was a problem hiding this comment.
P2: 입출력은 main 함수에서만 수행하는 것이 좋습니다. main에서 str을 입력 받은 후 checkSame 함수에 인자로 넘겨주는 식으로 수정하면 어떨까요?
Comment on lines
+20
to
+27
| ts_len=temp.size(); | ||
| int same=0; | ||
|
|
||
| int ts_al[26]; | ||
|
|
||
| for(int i=0; i<26; ++i){ | ||
| ts_al[i]=al[i]; | ||
| } |
There was a problem hiding this comment.
P3: 두 단어의 다른 구성을 세는 대신 같은 구성을 세는 식으로 문제를 풀어주셨네요! 이 방법도 좋지만 매번 ts_al에 al의 구성을 복사해야 하는 번거로움이 있으므로, 다른 구성을 세는 식으로 푸는 방법도 고민해보시면 좋을 것 같아요!
Comment on lines
+49
to
+52
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
P3: 불필요한 공백을 지워주시면 코드의 가독성을 높일 수 있습니다!
chaeri93
approved these changes
Mar 22, 2024
|
|
||
| if(temp==0){ | ||
| if(pq.empty()){ | ||
| cout << "-1" << "\n"; |
|
|
||
| using namespace std; | ||
|
|
||
| int findNum(int N){ |
There was a problem hiding this comment.
전체적으로 잘 구현해주셨네요,,..! 다만 입출력은 메인함수에서 하는것을 권장드립니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
학번: 2276107
이름: 문재원
##과제 제출
기존 제출: 2075, 2607, 14235