[DFS, BFS] 4월 9일 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyongdodam
approved these changes
Apr 12, 2024
Comment on lines
+7
to
+25
| void bfs(int v, const vector<vector<int>>& arr, vector<bool>& visited) { | ||
| queue<int> q; | ||
| q.push(v); | ||
| visited[v] = true; | ||
|
|
||
| int cnt = 0; | ||
|
|
||
| while (!q.empty()) { | ||
| v = q.front(); | ||
| q.pop(); | ||
|
|
||
| for (size_t i = 1; i < arr[v].size(); ++i) { | ||
| if (arr[v][i] == 1 && !visited[i]) { | ||
| q.push(i); | ||
| visited[i] = true; | ||
| cnt++; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
P3: bfs 흐름 너무 좋습니다!
하나만 매개변수에 하나만 const를 붙인 이유가 따로 있나요??
| int is_visited[101]; | ||
|
|
||
| // 깊이 우선 탐색 함수 | ||
| void depth_first_search(int current, int end, int steps) { |
There was a problem hiding this comment.
P3: 개인의 선택이지만 변수 : 스네이크 표기법, 함수 : 카멜 표기법 을 권장드리고 있습니다!!
There was a problem hiding this comment.
P3: 두 문제에서 bfs와 dfs 전부 잘 활용하여 푸셨네요 최곱니다~
chaeri93
approved these changes
Apr 14, 2024
| #include <iostream> | ||
| #include <vector> | ||
|
|
||
| #define MAX 19 |
There was a problem hiding this comment.
바둑판의 크기를 상수로 미리 정의해두고 사용해주셨네요! 이런 식으로 반복해서 사용하는 숫자는 하드코딩하는 것보다 상수로 선언하는게 숫자를 잘못 적을 가능성도 적어지고, 유지보수할 때도 좋아요 👍👍👍
| using namespace std; | ||
|
|
||
| vector<vector<char>> graph(MAX, vector<char>(MAX)); | ||
| vector<vector<vector<vector<bool>>>> visited(MAX, vector<vector<vector<bool>>>(MAX, vector<vector<bool>>(4, vector<bool>(2, false)))); |
There was a problem hiding this comment.
P3: 현재 4차원 배열을 생성하신것으로 보이는데 이차원 배월로 수정해주시면 더 가독성이나 효율성 측면에서 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
인적사항
학번 : 2076378
이름 : 정윤선
과제제출
기존 제출 : 2606, 2615, 2644
추가 제출 :