Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with theoldreader.com API #15

Open
bor opened this issue Jan 15, 2016 · 5 comments
Open

compatibility with theoldreader.com API #15

bor opened this issue Jan 15, 2016 · 5 comments

Comments

@bor
Copy link

bor commented Jan 15, 2016

Hello,

Thanks for sharing a great app! Especially on f-droid repo.

I have tried to use it with theoldreader.com account.
And have some issue.
Login, initial sync seems like OK, but sync after (marked) read smth is fail.
I have got errors like:

  • Sync failed: Invalid HTTP status 404 ... /api/0/stream/contents/user/-/label/labelname?n=...
  • Sync failed: Invalid JSON
  • Sync failed: Invalid long: "123abc..."

I think a source of issues can be in a some difference to Google Reader API.
There is an API link: https://github.com/theoldreader/api

Is it possible to fix those issues?

@Alkarex
Copy link
Owner

Alkarex commented Jan 25, 2016

Yes, there are indeed a few differences between the original Google Reader API and TheOldReader. It should be possible to make a special case when detecting TheOldReader server without too many changes. I cannot promise to find time for that soon, but would welcome a patch.

@scastrorico
Copy link
Collaborator

I use this app for theoldreader.com with this change. Seemingly the problem was that theoldreader.com API use ObjectId type for identifiers, and app parse it to Long. This generate a NumberFormatException.

Using ObjectID string value as UIDs in app if this exception was thrown solved the problem.
https://gist.github.com/scastrorico/b03958d5cf2d9cf93083

@Alkarex
Copy link
Owner

Alkarex commented Mar 28, 2016

#20

@Alkarex
Copy link
Owner

Alkarex commented Mar 28, 2016

Thanks for the patch, @scastrorico

@Alkarex
Copy link
Owner

Alkarex commented Apr 9, 2016

I have cherry-picked from @scastrorico patch c4f4a1b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants