Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache bundles in bundleAndInstall of setUpZoeForTest #10427

Open
turadg opened this issue Nov 8, 2024 · 0 comments · May be fixed by #10554 or #10430
Open

cache bundles in bundleAndInstall of setUpZoeForTest #10427

turadg opened this issue Nov 8, 2024 · 0 comments · May be fixed by #10554 or #10430
Labels
enhancement New feature or request

Comments

@turadg
Copy link
Member

turadg commented Nov 8, 2024

What is the Problem Being Solved?

To unit test starting a contract with a ZCF requires a Zoe service. Starting one of those requires installing a bundle.

setUpZoeForTest has bundleAndInstall to help. But it doesn't cache. So we have lots of tests that set up a bundle cache to then pass a cached bundle.

Description of the Design

Make bundleAndInstall cache.

Remove pre-caching from tests using bundleAndInstall.

Maybe also migrate direct uses of E(zoe).install(bundle) use setUpZoeForTest and its caching bundleAndInstall.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@turadg turadg added the enhancement New feature or request label Nov 8, 2024
@dckc dckc linked a pull request Nov 22, 2024 that will close this issue
3 tasks
@turadg turadg linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant