Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contract upgrade: governance contracts #10411

Open
Chris-Hibbert opened this issue Nov 6, 2024 · 0 comments
Open

Contract upgrade: governance contracts #10411

Chris-Hibbert opened this issue Nov 6, 2024 · 0 comments
Labels
contract-upgrade enhancement New feature or request Governance Governance

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

As mentioned in #8158, we need the ability to restart all vats. This issue is concerned with upgrading the contract governors.

Description of the Design

Contract Governors are built from contractGovernor.js.

We were able to null upgrade vaultFactory-governor in U16-VA, which shows governor vats are safely upgradeable. There's no value in upgrading governors for contracts (like auctions) that will be replaced rather than upgraded.

Security Considerations

no special considerations

Scaling Considerations

not a scaling concern.

Test Plan

We've demonstrated that it works in general, so we only need a3p tests that the proposal is upgrading the intended thing.

Upgrade Considerations

see above.

@Chris-Hibbert Chris-Hibbert added enhancement New feature or request Governance Governance contract-upgrade labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade enhancement New feature or request Governance Governance
Projects
None yet
Development

No branches or pull requests

1 participant