Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSGi support for Java HTTP Client #3276

Open
kwin opened this issue Feb 26, 2024 · 1 comment · May be fixed by #3280
Open

OSGi support for Java HTTP Client #3276

kwin opened this issue Feb 26, 2024 · 1 comment · May be fixed by #3280
Labels
feature request

Comments

@kwin
Copy link
Contributor

kwin commented Feb 26, 2024

There is already OSGi configuration support for Apache HTTP Client in https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/http/impl/HttpClientFactoryImpl.java.

Similar support for Java 11+ HTTP Client would be beneficial as well. That should comprise:

  1. Management of proxy settings via configuration factories and an OSGi service implementing java.net.ProxySelector
  2. Configuration and lifecycle management of Clients which allows to configure
    • TrustStore being used (the one from AEM vs the one from the JRE)
    • KeyStore being used (one of a specific AEM user or the one from the JRE)
    • Timeouts
    • Base URL
    • Disabling certificate checks
    • Authentication (Basic Auth and Certificate based)
@kwin
Copy link
Contributor Author

kwin commented Feb 26, 2024

@davidjgonzalez Can you clarify if such a feature clashes with a product feature on Adobe's roadmap?

@kwin kwin mentioned this issue Feb 26, 2024
Open
kwin added a commit that referenced this issue Feb 28, 2024
@kwin
OSGi support for Java HTTP Client
c56ac13 
This closes #3276
@kwin kwin linked a pull request Feb 28, 2024 that will close this issue
Draft
kwin added a commit that referenced this issue Feb 29, 2024
@kwin
OSGi support for Java HTTP Client
7a8bbfe 
This closes #3276
kwin added a commit that referenced this issue Mar 2, 2024
@kwin
OSGi support for Java HTTP Client
d211b53 
This closes #3276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OSGi support for Java HTTP Client Adobe-Consulting-Services/acs-aem-commons
1 participant
@kwin