Setharika Sok task-list-api #118
Conversation
| 'id':self.task_id, | ||
| 'title':self.title, | ||
| 'description':self.description, | ||
| 'is_complete': True if self.completed_at else False, |
There was a problem hiding this comment.
Love the ternary you implemented here!
| abort(make_response({"details":"Invalid data"}, 400)) | ||
|
|
||
| elif not request_body.get("description") and cls == Task: |
There was a problem hiding this comment.
We could write the conditions for this logic in one line like this:
if not (request_body.get('title') or request_body.get('description')):There was a problem hiding this comment.
We could also generalize your validate_request function to check for any request body like this:
def validate_request_body(request_body, keys):
for key in keys:
if not request_body.get(key):
abort(make_response({
'Invalid Data': f'missing key: {key}'
}, 400))
return TrueWe can pass in the request_body and a list of strings that are keys and then check to see if those keys are present.
| tasks = Task.query.filter_by(title = title_query) | ||
|
|
||
| elif description_query: |
| tasks = Task.query.order_by(Task.title.asc()) | ||
|
|
||
| elif sort_query == "desc": | ||
| tasks = Task.query.order_by(Task.title.desc()) | ||
|
|
||
| elif title_query: | ||
| tasks = Task.query.filter_by(title = title_query) |
There was a problem hiding this comment.
Nice work on getting the database to do most of the lifting when it comes to sorting the tasks
| task.description = request_body["description"] |
There was a problem hiding this comment.
Right now, if a user sends a request without the keys title or description your server would crash. There's a couple of ways to handle this, you could call the validate_request function before you access the keys in request_body or you could implement a try/except block.
| response = requests.post('https://slack.com/api/chat.postMessage', json=slack_data, headers=headers) | ||
| response.raise_for_status() | ||
|
|
||
| except requests.exceptions.RequestException as e: | ||
| return jsonify({'message': 'Failed to send Slack notification: {e}'}) |
There was a problem hiding this comment.
Nice work with the try/except clause and on having your Slack post sent after the logic of marking a task complete! We don't want to send out any false positive alerts just in case our logic fails during the update!
| for goal in goals: | ||
| goals_response.append({ "title": goal.title, "id": goal.goal_id}) |
There was a problem hiding this comment.
Do you think that this could be a class method? If so, how would your code look different?
| abort(400) | ||
|
|
||
| goal.task_ids = task_ids |
There was a problem hiding this comment.
So here you are making a new attribute on this goal instance that will hold a list of task ids that were last added. This doesn't actually make an association between the two models. Lines 228 and 229 take care of that.
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Well done on this project, I didn't have much to comment on and that is a good thing! Keep up the good work! Really looking forward to what you create in the frontend! Please feel free to reach out if you have any questions about the feedback that I left! ✨💫🤭
No description provided.