New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby Class - Kimberly Lantigua #83

Open

kimcodes3 wants to merge 10 commits into Ada-C19:main from kimcodes3:main

kimcodes3 commented Apr 7, 2023

No description provided.

kimcodes3 added 10 commits

April 3, 2023 13:59


          Implemented the Vendor Class (constructor, add/remove methods). Finis…

6e38b13

…hed writing the last test in test_wave_01 and passed all associated tests


          partially defined Item class (constructor, get_category). Passed 4/6 …

b281e40

…tests in test_wave_02


          completed get_by_id method in vendor class and passed test_wave_02.py

f7e559c


          implemented the stringify method in the Item class and defined the sw…

a6fb3c6

…ap_items method in the vendor class. Passed all associated tests in the test_wave_03 file


          passed the test_wave_01_02_03.py integration test :)

d8362ed


          Defined swap_first_item method in Vendor Class and passed all tests i…

c44123c

…n test_wave_04.py


          implemented the Clothing class and passed associated tests in test_wa…

f26aea4

…ve_05. Interesting glitch with if else in the constructor that I need to bring up with an instructor/ TA


          Modified the Items class, defined the decor, clothing, and electronic…

9a68fdc

…s classes. Made all 3 child classes of Itemclass and used super() to access attributes/methods in the parent class. Passed all tests in test_wave_05.py


          defined functions for wave 6 (get by category, get best by category, …

aaf42ef

…and swap best by category) and defined remaining tests in test_wave_06.py. All tests passed, including the integration tests! :)


          Made final edits and ensured code was refactored to best of my abilit…

7990f99

…y :)

nancy-harris reviewed

View reviewed changes

nancy-harris left a comment

Excellent job! Your code was very clean and concise! I left some comments below on some changes that could be made for the tests. Great job making commits often and making the commit messages descriptive!

swap_meet/clothing.py

		from swap_meet.item import Item

		class Clothing(Item):

nancy-harris Apr 7, 2023

Excellent!

swap_meet/decor.py

		from swap_meet.item import Item

		class Decor(Item):

nancy-harris Apr 7, 2023

Excellent!

swap_meet/electronics.py

-                  pass
+              from swap_meet.item import Item
+              class Electronics(Item):

nancy-harris Apr 7, 2023

Excellent!

swap_meet/item.py

		@@ -1,2 +1,35 @@
		import uuid

		class Item:

nancy-harris Apr 7, 2023

Excellent!

swap_meet/vendor.py


		# constructor for the vendor class
		def __init__(self, inventory = None):

nancy-harris Apr 7, 2023

Excellent!

tests/unit_tests/test_wave_06.py

Comment on lines +40 to +41

		assert not items
		assert len(items) == 0

nancy-harris Apr 7, 2023

Only the second assert is needed. It is more accurate to what we are looking for and if len(items) is 0, we know for sure that it's falsey, so we don't need the first assert.

tests/unit_tests/test_wave_06.py

Comment on lines +121 to +131

+                  assert result
+                  assert len(tai.inventory) == 3
+                  assert len(jesse.inventory) == 3
+                  assert item_a in tai.inventory
+                  assert item_b in tai.inventory
+                  assert item_c not in tai.inventory
+                  assert item_f in tai.inventory
+                  assert item_d in jesse.inventory
+                  assert item_e in jesse.inventory
+                  assert item_f not in jesse.inventory
+                  assert item_c in jesse.inventory

nancy-harris Apr 7, 2023

Excellent!

tests/unit_tests/test_wave_06.py

Comment on lines +165 to +175

+                  assert result
+                  assert len(tai.inventory) == 3
+                  assert len(jesse.inventory) == 3
+                  assert item_a in tai.inventory
+                  assert item_b in tai.inventory
+                  assert item_c not in tai.inventory
+                  assert item_f in tai.inventory
+                  assert item_d in jesse.inventory
+                  assert item_e in jesse.inventory
+                  assert item_f not in jesse.inventory
+                  assert item_c in jesse.inventory

nancy-harris Apr 7, 2023

Excellent!

tests/unit_tests/test_wave_06.py

Comment on lines +265 to +273

+                  assert not result
+                  assert len(tai.inventory) == 3
+                  assert len(jesse.inventory) == 3
+                  assert item_a in tai.inventory
+                  assert item_b in tai.inventory
+                  assert item_c in tai.inventory
+                  assert item_d in jesse.inventory
+                  assert item_e in jesse.inventory
+                  assert item_f in jesse.inventory

nancy-harris Apr 7, 2023

Excellent!

tests/unit_tests/test_wave_06.py

Comment on lines +308 to +316

+                  assert not result
+                  assert len(tai.inventory) == 3
+                  assert len(jesse.inventory) == 3
+                  assert item_a in tai.inventory
+                  assert item_b in tai.inventory
+                  assert item_c in tai.inventory
+                  assert item_d in jesse.inventory
+                  assert item_e in jesse.inventory
+                  assert item_f in jesse.inventory

nancy-harris Apr 7, 2023

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet