Ruby - Laura Perez #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Excellent job! I left comments below on places where the code could be cleaner/simpler. Great job on adding commits often! It would be great if the commit messages could be more descriptive about the changes that were made to the code. Something like "Created Vendor class" would be great!
| from swap_meet.item import Item | ||
| class Clothing(Item): |
| @@ -1,2 +1,13 @@ | |||
| class Decor: | |||
| from swap_meet.item import Item | |||
| class Decor(Item): | |||
| @@ -1,2 +1,9 @@ | |||
| class Electronics: | |||
| pass | |||
| from swap_meet.item import Item | |||
| @@ -1,2 +1,44 @@ | |||
| import uuid | |||
|
|
|||
| class Item: | |||
| def __init__(self, inventory=None): |
Comment on lines
+107
to
+115
| assert result is True | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_c in jesse.inventory | ||
| assert item_f in tai.inventory | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory |
Comment on lines
+148
to
+156
| assert result is True | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_c in jesse.inventory | ||
| assert item_f in tai.inventory | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory |
Comment on lines
+239
to
+247
| assert not result | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory | ||
| assert item_c in tai.inventory | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_f in jesse.inventory |
Comment on lines
+280
to
+288
| assert not result | ||
| assert len(tai.inventory) == 3 | ||
| assert len(jesse.inventory) == 3 | ||
| assert item_a in tai.inventory | ||
| assert item_b in tai.inventory | ||
| assert item_c in tai.inventory | ||
| assert item_d in jesse.inventory | ||
| assert item_e in jesse.inventory | ||
| assert item_f in jesse.inventory |
|
|
||
| #swap by newest | ||
| #my_tests: | ||
| def test_swap_by_newest(): |
There was a problem hiding this comment.
Excellent job adding your own tests for the optional enhancements you did!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.