Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amethyst - Setharika Sok #84

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 127 additions & 1 deletion src/adagrams.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,141 @@
export const drawLetters = () => {
// Implement this method for wave 1
const letters = {
'A': 9,
'B': 2,
'C': 2,
'D': 4,
'E': 12,
'F': 2,
'G': 3,
'H': 2,
'I': 9,
'J': 1,
'K': 1,
'L': 4,
'M': 2,
'N': 6,
'O': 8,
'P': 2,
'Q': 1,
'R': 6,
'S': 4,
'T': 6,
'U': 4,
'V': 2,
'W': 2,
'X': 1,
'Y': 2,
'Z': 1
};

const drawnHand = [];
const allList = Object.entries(letters)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Rika! This is a clever use of the Object.entries method!


while (drawnHand.length < 10){
const randomNumber = Math.floor(Math.random() * allList.length);
const drawnLetter = allList[randomNumber]

if (drawnHand.filter(letter => letter === drawnLetter[0]).length < drawnLetter[1]) {
drawnHand.push(drawnLetter[0])
}

}
return (drawnHand);
}

export const usesAvailableLetters = (input, lettersInHand) => {
// Implement this method for wave 2
};
// console.log(`input: ${input} lettersInHand ${lettersInHand}`)
let letterCount = 0
for (let i of lettersInHand){
for (let j of input){
if (i.toUpperCase() === j.toUpperCase()) {
++letterCount;
break;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}
}
}
if (letterCount == input.length) {
// console.log("=> True");
return true;
}
else {
// console.log("=> False");
return false;
}
}

export const scoreWord = (word) => {
// console.log(`word ${word}`);
// Implement this method for wave 3
const points = {
'A': 1,
'B': 3,
'C': 3,
'D': 2,
'E': 1,
'F': 4,
'G': 2,
'H': 4,
'I': 1,
'J': 8,
'K': 5,
'L': 1,
'M': 3,
'N': 1,
'O': 1,
'P': 3,
'Q': 10,
'R': 1,
'S': 1,
'T': 1,
'U': 1,
'V': 4,
'W': 4,
'X': 8,
'Y': 4,
'Z': 10
}
let sumPoint = 0
for (let letter of word.toUpperCase()) {
sumPoint += points[letter];
}
if (word.length >= 7 && word.length <= 10) {
sumPoint += 8;
}
// console.log(`sumPoint ${sumPoint}`);
return sumPoint;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💫


};

export const highestScoreFrom = (words) => {
// Implement this method for wave 4
let winnerWord = "";
let winnerScore = 0;
Comment on lines +114 to +115

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we know we want to return these variables in object form, could just initialize said object here?

let winner = {};

for (let word of words) {
let score = scoreWord(word);
winner[word] = score;
}

for (let [word,score] of Object.entries(winner)) {
if (winnerScore < score) {
winnerScore = score;
winnerWord = word;
}
else if (winnerScore === score && word.length === 10 && winnerWord.length !== 10) {
winnerScore = score;
winnerWord = word;
}
else if (winnerScore === score && word.length < winnerWord.length && winnerWord.length !== 10) {
winnerScore = score;
winnerWord = word;
}
Comment on lines +124 to +135

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to follow! I love the compound if statements that you made as well!

}
console.log({ score: winnerScore, word: winnerWord })
return { score: winnerScore, word: winnerWord };

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, Rika! As you probably noticed, I didn't give too much feedback due to the scope of the project (Translating your python code to Javascript code). I tried to just point out any glaring issues, if any. With that being said, if you want to discuss anything in greater detail, feel free to reach out to me!

};


13 changes: 9 additions & 4 deletions test/adagrams.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,10 @@ describe("Adagrams", () => {
});

it("returns a score of 0 if given an empty input", () => {
throw "Complete test";
// throw "Complete test";
expectScores({
'': 0,
});
});

it("adds an extra 8 points if word is 7 or more characters long", () => {
Expand All @@ -133,7 +136,7 @@ describe("Adagrams", () => {
});
});

describe.skip("highestScoreFrom", () => {
describe("highestScoreFrom", () => {
it("returns a hash that contains the word and score of best word in an array", () => {
const words = ["X", "XX", "XXX", "XXXX"];
const correct = { word: "XXXX", score: scoreWord("XXXX") };
Expand All @@ -145,7 +148,9 @@ describe("Adagrams", () => {
const words = ["XXX", "XXXX", "X", "XX"];
const correct = { word: "XXXX", score: scoreWord("XXXX") };

throw "Complete test by adding an assertion";
// throw "Complete test by adding an assertion";
expect(highestScoreFrom(words)).toEqual(correct);
});
});

describe("in case of tied score", () => {
Expand Down Expand Up @@ -196,4 +201,4 @@ describe("Adagrams", () => {
});
});
});
});
// });