Amethyst - Setharika Sok #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikellewade
reviewed
Jul 17, 2023
| }; | ||
|
|
||
| const drawnHand = []; | ||
| const allList = Object.entries(letters) |
There was a problem hiding this comment.
Nice Rika! This is a clever use of the Object.entries method!
mikellewade
reviewed
Jul 17, 2023
| for (let j of input){ | ||
| if (i.toUpperCase() === j.toUpperCase()) { | ||
| ++letterCount; | ||
| break; |
mikellewade
reviewed
Jul 17, 2023
| sumPoint += 8; | ||
| } | ||
| // console.log(`sumPoint ${sumPoint}`); | ||
| return sumPoint; |
mikellewade
reviewed
Jul 17, 2023
Comment on lines
+114
to
+115
| let winnerWord = ""; | ||
| let winnerScore = 0; |
There was a problem hiding this comment.
If we know we want to return these variables in object form, could just initialize said object here?
mikellewade
reviewed
Jul 17, 2023
Comment on lines
+124
to
+135
| if (winnerScore < score) { | ||
| winnerScore = score; | ||
| winnerWord = word; | ||
| } | ||
| else if (winnerScore === score && word.length === 10 && winnerWord.length !== 10) { | ||
| winnerScore = score; | ||
| winnerWord = word; | ||
| } | ||
| else if (winnerScore === score && word.length < winnerWord.length && winnerWord.length !== 10) { | ||
| winnerScore = score; | ||
| winnerWord = word; | ||
| } |
There was a problem hiding this comment.
Easy to follow! I love the compound if statements that you made as well!
mikellewade
reviewed
Jul 17, 2023
| } | ||
| } | ||
| console.log({ score: winnerScore, word: winnerWord }) | ||
| return { score: winnerScore, word: winnerWord }; |
There was a problem hiding this comment.
Nice job, Rika! As you probably noticed, I didn't give too much feedback due to the scope of the project (Translating your python code to Javascript code). I tried to just point out any glaring issues, if any. With that being said, if you want to discuss anything in greater detail, feel free to reach out to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.