[Fix/#320] 자잘한 스타일링, 라이팅 변경 #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljh0608
approved these changes
Aug 29, 2024
| @@ -9,10 +9,11 @@ interface ValueProps { | |||
| value: string; | |||
| setValue: (e: React.ChangeEvent<HTMLInputElement>) => void; | |||
| resetValue: () => void; | |||
| max: number; | |||
There was a problem hiding this comment.
p3) input의 최대 길이를 나타내는 props가 맞다면 maxLength 네이밍을 고려해보셔도 좋을 것 같습니다!
| @@ -44,6 +40,7 @@ function SetHostInfo({ meetingInfo, setMeetingInfo, setStep }: FunnelProps) { | |||
| } | |||
| }; | |||
|
|
|||
| console.log(meetingInfo.password.length); | |||
There was a problem hiding this comment.
p3) console 이 자주 올라오진 않지만! eslint 옵션중 console 에러로 인식하도록 변경하는거 어떠신가요?? 이 부분 이번주 회의 때 얘기해보면 좋겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌀 해당 이슈 번호
🔹 어떤 것을 변경했나요?
🔹 어떻게 구현했나요?
🔹 PR 포인트를 알려주세요!
현재 바로 적용 불가한 사항
🔹 스크린샷을 남겨주세요!