Compile-time edge module compilation check, native support for ConstMapObserver #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update frida crate to the latest version * adapt libafl_frida to the latest version of frida
replaced OwnedSlice in ConstMapObserver by the new OwnedSizedSlice.
domenukk
reviewed
Oct 18, 2024
domenukk
approved these changes
Oct 18, 2024
|
|
Status? |
domenukk
reviewed
Oct 25, 2024
domenukk
approved these changes
Oct 25, 2024
|
You can try if the |
domenukk
reviewed
Nov 3, 2024
fuzzers/baby/backtrace_baby_fuzzers/c_code_with_fork_executor/src/main.rs
Outdated
Show resolved
Hide resolved
domenukk
reviewed
Nov 3, 2024
|
good to go @domenukk or is there something else to discuss? |
domenukk
reviewed
Nov 4, 2024
domenukk
reviewed
Nov 4, 2024
fuzzers/baby/backtrace_baby_fuzzers/c_code_with_fork_executor/src/main.rs
Outdated
Show resolved
Hide resolved
domenukk
reviewed
Nov 4, 2024
|
|
||
| impl StdEdgeCoverageClassicModule { | ||
| #[must_use] | ||
| pub fn builder() -> StdEdgeCoverageClassicModuleBuilder { |
There was a problem hiding this comment.
At some point it would be beautiful to start documenting anything... Like, what does classic mean?
domenukk
reviewed
Nov 4, 2024
| @@ -150,37 +148,30 @@ where | |||
| } | |||
| } | |||
|
|
|||
| impl<T, const N: usize> VariableLengthMapObserver for ConstMapObserver<'_, T, N> | |||
| impl<T, const N: usize> ConstantLengthMapObserver<N> for ConstMapObserver<'_, T, N> | |||
There was a problem hiding this comment.
How about renaming them to ConstLenMapObserver and VarLenMapObserver btw? Seems shorter and just as to clear.
Random idea of course, feel free to ignore.
There was a problem hiding this comment.
ok for me, both work out imho
|
Feel free to merge after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up of the patches i introduced in #2520 on edge module.
it improves how map_observer guarantees are done at compile-time when building an edge module, with a nicer error message in case the right function is not called.