Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include IR-Remote #1

Closed
ADeadTrousers opened this issue Jan 25, 2021 · 3 comments
Closed

Include IR-Remote #1

ADeadTrousers opened this issue Jan 25, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@ADeadTrousers
Copy link
Owner

Stock ROM includes a handy little app to use as an universal infrared remote. At first I planned to include it but now I'm not so sure anymore:

  • Since the last update there are far more additional libraries needed.
  • Most of these hint a connection with alibaba/baidu (chineese google).
  • I read some reviews that it comes with a default set of devices and is not able to "learn" new instructions.

So that's enough for me not to include it. This issus is therfore a "wontfix" for now and serves as a explanation.
Maybe some time later when I have the time I'll search for a working (open source!) alternative to include instead.

@ADeadTrousers ADeadTrousers self-assigned this Jan 25, 2021
@SepticFuddy
Copy link

SepticFuddy commented Jan 26, 2021

The people in this Reddit thread all recommend either irplus or Mi Remote controller. Neither is open source, though they both apparently work fine with all permissions disabled. Irplus seems to be very simple and highly configurable at least, with code updates on GitHub- I downloaded the Play version to check it out. Nonetheless, not for including here.

I did find this open source one called IR Remote. I downloaded the Play version (called Universal TV Remote), and it also seems very configurable and simple. However, the latest update on GitHub is from Jul 2014 whereas the latest update on Play is from Dec 2015. Build instructions say to clone his library project, but the link to it is broken, as he seems to have missed an 'S'. I encountered a build error I don't know how to resolve, so I can't vouch for the open source version. Given my lack of experience, the error is probably very something very basic and trivial: Error:Module 'IR-Remote-master' production: java.lang.NoClassDefFoundError: com/android/resources/ResourceFolderType.

@ADeadTrousers
Copy link
Owner Author

ADeadTrousers commented Jan 27, 2021

ResourceFolderType sounds to me like it's missing some images, sounds and so on.
But like you said the IR Remote is pretty much out of the way. That additional library it requires looks like a custom made UI library so I would not recommend using it. Android Studio and any other App development solution have way better UI libraries included and they are also continuously updated.
irplus looks promising. At least their Homepage is on github.io so I think their main repository should be there too but marked as private. It doesn't really make any sense to have the one without the other.
But I don't think I would be (legally) allowed to integrate the app (either as apk or in code) into my ROM.

@ADeadTrousers
Copy link
Owner Author

Great news. I just tested irplus and it works fine.

@ADeadTrousers ADeadTrousers transferred this issue from ADeadTrousers/android_device_Unihertz_Atom_XL_EEA Mar 10, 2021
@ADeadTrousers ADeadTrousers pinned this issue Mar 10, 2021
@ADeadTrousers ADeadTrousers added the wontfix This will not be worked on label Mar 10, 2021
@ADeadTrousers ADeadTrousers added the enhancement New feature or request label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants