Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch the infinite loop when BlurringView is a child of the view that will be blurred #33

Open
ndbroadbent opened this issue Apr 11, 2017 · 0 comments

Comments

@ndbroadbent
Copy link

ndbroadbent commented Apr 11, 2017

I've been spending some time fixing up the react-native-blur library, which is not great on Android. The docs need some updates, but right now their suggested usage works on iOS, and can cause an infinite loop on Android.

I think it might be a good idea to add a check in BlurringView, to make sure that there are no circular references that would cause an infinite loop (where the BlurringView is trying to to draw itself).

Not just for React Native developers, but for any other Android developers who might do this by accident, and wonder why their app is just freezing before crashing from a stack overflow.

I don't have a ton of experience with Android, but I can try to submit a PR if you think this is a reasonable idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant