Updated to pyyaml 6.0 and generate-local-access-key script and remove access_key.py/json #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willronchetti
approved these changes
Aug 25, 2023
netsettler
reviewed
Sep 18, 2023
|
|
||
| * Added generate-local-access-key script (from snovault) to pyproject.toml; | ||
| orignally created for smaht-portal since early in development no way to | ||
| create an access-key normally using the UI; but generall useful/convenient. |
There was a problem hiding this comment.
Suggested change
| create an access-key normally using the UI; but generall useful/convenient. | |
| create an access-key normally using the UI; but generally useful/convenient. |
| @@ -122,7 +122,7 @@ def anon_pipeline(): | |||
|
|
|||
|
|
|||
| def run(pipeline, inpath, outpath): | |||
| for item_type in ORDER: | |||
| for item_type in ORDER(): | |||
There was a problem hiding this comment.
See my related comment on your snovault PR, but I found it really weird to see (a) a function here that is all-uppercase, and (b) a change in the semantics of ORDER, which had previously been a list. I think if the semantics changes in so strong a way, it should just have a different name, so that it doesn't look to someone who doesn't know about the name like you've used it wrong.
So my suggestion is to rename the function to something like load_order_for_app in the other PR and then use the newly chosen name here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orignally created for smaht-portal since early in development no way to
create an access-key normally using the UI; but generall useful/convenient.