-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert IRC formatting / emphasis to markdown for Mattermost #546
Open
hloeung
wants to merge
6
commits into
42wim:master
Choose a base branch
from
hloeung:convert-formatting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
convert-formatting
branch
from
September 16, 2023 11:43
41ab91d
to
4a3948c
Compare
hloeung
force-pushed
the
convert-formatting
branch
2 times, most recently
from
September 16, 2023 23:36
fbb00d7
to
2df932d
Compare
hloeung
force-pushed
the
convert-formatting
branch
from
September 16, 2023 23:37
2df932d
to
df35e47
Compare
hloeung
changed the title
Convert IRC formatting / emphasis to markdown
Convert IRC formatting / emphasis to Markdown to Mattermost
Sep 17, 2023
hloeung
changed the title
Convert IRC formatting / emphasis to Markdown to Mattermost
Convert IRC formatting / emphasis to Markdown for Mattermost
Sep 27, 2023
hloeung
changed the title
Convert IRC formatting / emphasis to Markdown for Mattermost
Convert IRC formatting / emphasis to markdown for Mattermost
Sep 27, 2023
Added stripping of reverse and hex colors, so this covers all the cases as per #258 |
Not tested yet by me, but looks good :) |
NightTsarina
added a commit
to Tina-pm/matterircd
that referenced
this pull request
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #258
Per #258, this converts formatting/emphasis of IRC messages to markdown to Mattermost. Currently supported are bold, italics, bold+italics, monospace, and reset.
Testing with
irssi
(which doesn't seem to let me test italics and monospace):(where B = Ctrl+B and O = Ctrl+O)
Produces:
Testing Testing Testing Testing Testing (reset)