Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert IRC formatting / emphasis to markdown for Mattermost #546

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hloeung
Copy link
Collaborator

@hloeung hloeung commented Sep 16, 2023

This fixes #258

Per #258, this converts formatting/emphasis of IRC messages to markdown to Mattermost. Currently supported are bold, italics, bold+italics, monospace, and reset.

Testing with irssi (which doesn't seem to let me test italics and monospace):

> Testing BTestingB Testing BTestingO Testing (reset)

(where B = Ctrl+B and O = Ctrl+O)

Produces:

Testing Testing Testing Testing Testing (reset)

@hloeung hloeung force-pushed the convert-formatting branch 2 times, most recently from fbb00d7 to 2df932d Compare September 16, 2023 23:36
@hloeung hloeung mentioned this pull request Sep 16, 2023
@hloeung hloeung changed the title Convert IRC formatting / emphasis to markdown Convert IRC formatting / emphasis to Markdown to Mattermost Sep 17, 2023
@hloeung hloeung requested a review from 42wim September 20, 2023 05:40
@hloeung hloeung changed the title Convert IRC formatting / emphasis to Markdown to Mattermost Convert IRC formatting / emphasis to Markdown for Mattermost Sep 27, 2023
@hloeung hloeung changed the title Convert IRC formatting / emphasis to Markdown for Mattermost Convert IRC formatting / emphasis to markdown for Mattermost Sep 27, 2023
@hloeung hloeung marked this pull request as ready for review September 27, 2023 11:12
@hloeung hloeung marked this pull request as draft September 27, 2023 20:33
@hloeung hloeung marked this pull request as ready for review September 27, 2023 22:18
@hloeung
Copy link
Collaborator Author

hloeung commented Sep 27, 2023

Added stripping of reverse and hex colors, so this covers all the cases as per #258

@42wim
Copy link
Owner

42wim commented Sep 29, 2023

Not tested yet by me, but looks good :)

NightTsarina added a commit to Tina-pm/matterircd that referenced this pull request Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert formatting.
2 participants