Integrate flash.sh from RteCtrl #83
Conversation
Add flash.sh script from 3mdeb/RteCtrl#22. For more inf. check #80. Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
DaniilKl
force-pushed
the
integrate-flash-script
branch
from
3709f78
to
c4c0f2b
Compare
DaniilKl
force-pushed
the
integrate-flash-script
branch
from
c4c0f2b
to
b09e9b7
Compare
There was a problem hiding this comment.
flashrom -p "$FLASHROM_PROGRAMMER" "$FLASHROM_PARAMS"
Is wrong.
It results in:
root@rte:~# ./flash.sh -V 3.3V probe
Setting SPI VCC to 3.3V
SPI lines ON
SPI Vcc ON
Probing ...
flashrom 1.4.0 on Linux 6.6.28 (armv7l)
flashrom is free software, get the source code at https://flashrom.orgError: Extra parameter found.
Please run "flashrom --help" for usage info.
SPI Vcc OFF
SPI lines OFF
The fix would be:
flashrom -p "$FLASHROM_PROGRAMMER" $FLASHROM_PARAMS
So without the double quotes for the flashrom params.
I just made that change and tried:
root@rte:~# ./flash.sh -V 3.3V probe --flashrom-params "-o output.txt"
And that generated the output.txt file correctly, meaning that the flashrom params are still working, while now also without flashrom params.
Signed-off-by: Daniil Klimuk <[email protected]>
|
Thank you for your feedback. Fixed here ffda849. |
For more inf.:
3mdeb/RteCtrl#22
#80