[FEAT] 3차 과제 구현 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
넘넘 수고했어!! 차차 나랑 같이 더 발전시켜보자 ㅎㅣ히히 |
|
고생하셨습니다 당신 .. |
HELLOHIDI
reviewed
Nov 11, 2022
|
|
||
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| let components: [Any] = [view1, view2, view3, changeButton] |
There was a problem hiding this comment.
Any타입말고 UIView로 타입을 설정해주면 더 정확하고 좋을거 같아요~!
| private let startLabel: UILabel = { | ||
| let label = UILabel() | ||
| label.font = .systemFont(ofSize: 22, weight: .medium) | ||
| label.text = "카카오톡을 시작합니다" |
There was a problem hiding this comment.
텍스트 값 하드코딩하는 것 보다 리터럴 파일로 따로 관리하는 것도 추천드립니다!
Comment on lines
+70
to
+81
| var friendList:[FriendModel] = [ | ||
| FriendModel(name: "가솝트", status: "상태메시지", profileImage: "profileImage1"), | ||
| FriendModel(name: "나솝트", status: "상태메시지", profileImage: "profileImage2"), | ||
| FriendModel(name: "다솝트", status: "상태메시지", profileImage: "profileImage3"), | ||
| FriendModel(name: "라솝트", status: "상태메시지", profileImage: "profileImage4"), | ||
| FriendModel(name: "마솝트", status: "상태메시지", profileImage: "profileImage5"), | ||
| FriendModel(name: "바솝트", status: "상태메시지", profileImage: "profileImage6"), | ||
| FriendModel(name: "사솝트", status: "상태메시지", profileImage: "profileImage7"), | ||
| FriendModel(name: "아솝트", status: "상태메시지", profileImage: "profileImage8"), | ||
| FriendModel(name: "자솝트", status: "상태메시지", profileImage: "profileImage9"), | ||
| FriendModel(name: "차솝트", status: "상태메시지", profileImage: "profileImage9") | ||
| ] |
There was a problem hiding this comment.
더미데이터는 model 파일에서 관리하면 뷰컨트롤러가 더 깔끔할거 같아요!!!
Comment on lines
+193
to
+203
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, minimumLineSpacingForSectionAt section: Int) -> CGFloat { | ||
| return friendListLineSpacing | ||
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, minimumInteritemSpacingForSectionAt section: Int) -> CGFloat { | ||
| return friendListInterItemSpacing | ||
| } | ||
|
|
||
| func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, insetForSectionAt section: Int) -> UIEdgeInsets { | ||
| return friendListInset | ||
| } |
jeongkite
approved these changes
Nov 11, 2022
Comment on lines
+44
to
+47
| let components: [Any] = [view1, view2, view3, changeButton] | ||
| components.forEach { | ||
| view.addSubview($0 as! UIView) | ||
| } |
There was a problem hiding this comment.
생명주기함수 안에는 함수의 호출부만 써주는게 조금 더 깔끔해서 선호하는 사람들이 많답니당~ 참고하면 좋을 것 같아요우👍
Comment on lines
+50
to
+54
| @objc | ||
| private func changeBound() { | ||
| view2.bounds = CGRect(x: 98, y: 157, width: 300, height: 500) | ||
|
|
||
| } |
There was a problem hiding this comment.
이건 objc 함수로 쓰기보다 따로 설정해주는게 더 좋을 것 같아요! 개인적인 생각이지만 swift가 나온만큼, swift로 해줄 수 있는 부분이라면 최대한 활용하는게 좋지 않을까 싶습니다!
Comment on lines
+66
to
+84
| private let loginButton: UIButton = { | ||
| let button = UIButton() | ||
| button.setTitle("카카오계정 로그인", for: .normal) | ||
| button.setTitleColor(.black, for: .normal) | ||
| button.backgroundColor = 0xF6F6F6.color | ||
| button.titleLabel?.font = .systemFont(ofSize: 15, weight: .medium) | ||
| button.addTarget(self, action: #selector(presentToWelcomeVC), for: .touchUpInside) | ||
| return button | ||
| }() | ||
|
|
||
| private let signInButton: UIButton = { | ||
| let button = UIButton() | ||
| button.setTitle("새로운 카카오계정 만들기", for: .normal) | ||
| button.setTitleColor(.black, for: .normal) | ||
| button.backgroundColor = 0xF6F6F6.color | ||
| button.titleLabel?.font = .systemFont(ofSize: 15, weight: .medium) | ||
| button.addTarget(self, action: #selector(pushToSignUpVC), for: .touchUpInside) | ||
| return button | ||
| }() |
There was a problem hiding this comment.
겹치는 코드가 많다면 어떻게 짜야 코드를 최대한 덜 쓸 수 있을까 고민해봐도 좋을 것 같아요! 게으름은 개발자의 미덕..ㅋㅋㅋ
Comment on lines
+79
to
+84
| imageContainerView.snp.makeConstraints { | ||
| $0.centerY.equalToSuperview() | ||
| $0.leading.equalToSuperview().offset(16) | ||
| $0.height.equalTo(41) | ||
| $0.width.equalTo(41) | ||
| } |
jeongkite
reviewed
Nov 12, 2022
Comment on lines
+29
to
+32
| // Called when the user discards a scene session. | ||
| // If any sessions were discarded while the application was not running, this will be called shortly after application:didFinishLaunchingWithOptions. | ||
| // Use this method to release any resources that were specific to the discarded scenes, as they will not return. | ||
| } |
jeongkite
requested changes
Nov 12, 2022
Comment on lines
+23
to
+25
| // Called when a new scene session is being created. | ||
| // Use this method to select a configuration to create the new scene with. | ||
| return UISceneConfiguration(name: "Default Configuration", sessionRole: connectingSceneSession.role) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3차 과제 일단 되는 데까지 했습니다,,
깃허브 너무 어려워서 래포 새로 팠습니다.. 찬미님 너무 감사합니다. 과제는 추후 수정하도록 하겠습니다