Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podcast feed title unexpectedly adding site title #292

Open
1 task done
dabowman opened this issue Apr 18, 2024 · 0 comments · May be fixed by #295
Open
1 task done

Podcast feed title unexpectedly adding site title #292

dabowman opened this issue Apr 18, 2024 · 0 comments · May be fixed by #295
Assignees
Labels
type:bug Something isn't working.

Comments

@dabowman
Copy link

Describe the bug

Hello friends!

I just noticed this morning that my podcast feed title had started adding my site title and a double chevron character before the actual podcast title.

It should be rendering this:

<title>American Field Trip: A National Parks Podcast</title>

But instead, was rendering this:

<title>American Field Trip » American Field Trip: A National Parks Podcast</title>

I dug and dug and couldn't figure out where this was coming from. Finally, I started searching through the code here to see if there was something conflicting with my theme. A theme issue may still be the case for my specific issue but I found something that seems to be causing the problem.

It looks like this function here is rendering the feed title. I'm not great with PHP, but as far as I can tell, It checks for a podcasting_title row in the term_meta and if it doesn't find one it falls back to adding the blog name, a double chevron and then the term name—which is the title of the podcast. Looks like there was a PR a couple months ago to work on this function that functionality shipped with the latest 1.8 update.

There might be more going on here than I realize, but before that last update I'm pretty sure everything was working as expected. After that update the feed title started acting weird.

As far as I can tell, the plugin never creates this podcasting_title row in term_meta. I'd expect to see it in the list here with the rest of the custom meta

function get_meta_fields() {
. I went ahead and added podcasting_title manually to the term_meta for my podcast in my database and it resolved the issue!

What's weird is I don't think the reference to that podcasting_title meta was anything new. If that's the case, I don't know how everything was rendering correctly before. In any case, the plugin doesn't seem to be creating a row in term_meta for the podcast title and adding that row manually seems to make that function behave as expected and not fall back to the else portion of that function.

Hopefully this is helpful!

Steps to Reproduce

Create a new podcast, give it a name, check the feed title to see if it includes [blog name] &#187 before the expected title.

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

`

wp-core

version: 6.5.2
site_language: en_US
user_language: en_US
timezone: America/New_York
permalink: /blog/%year%/%monthnum%/%day%/%postname%/
https_status: true
multisite: false
user_registration: 0
blog_public: 1
default_comment_status: open
environment_type: production
user_count: 4
dotorg_communication: true

wp-paths-sizes

wordpress_path: /wordpress/core/6.5.2
wordpress_size: loading...
uploads_path: /srv/htdocs/wp-content/uploads
uploads_size: loading...
themes_path: /srv/htdocs/wp-content/themes
themes_size: loading...
plugins_path: /srv/htdocs/wp-content/plugins
plugins_size: loading...
database_size: loading...
total_size: loading...

wp-dropins (2)

advanced-cache.php: true
object-cache.php: true

wp-active-theme

name: Zeen Child (zeen-child)
version: 1.2.1
author: Codetipi
author_website: (undefined)
parent_theme: Zeen (zeen)
theme_features: core-block-patterns, title-tag, post-thumbnails, automatic-feed-links, woocommerce, wc-product-gallery-zoom, wc-product-gallery-lightbox, wc-product-gallery-slider, sensei, post-formats, menus, html5, customize-selective-refresh-widgets, align-wide, widgets
theme_path: /srv/htdocs/wp-content/themes/zeen-child
auto_update: Disabled

wp-parent-theme

name: Zeen (zeen)
version: 4.5.0
author: Codetipi
author_website: https://www.codetipi.com
theme_path: /srv/htdocs/wp-content/themes/zeen
auto_update: Disabled

wp-themes-inactive (3)

Storefront: version: 4.5.5, author: Automattic, Updates managed by Host
Twenty Seventeen: version: 3.6, author: the WordPress team, Updates managed by Host
Twenty Sixteen: version: 3.2, author: the WordPress team, Updates managed by Host

wp-plugins-active (15)

Akismet Anti-spam: Spam Protection: version: 5.3.2, author: Automattic - Anti-spam Team, Updates managed by Host
Block Gallery: version: 1.1.6, author: Rich Tabor, Auto-updates enabled
CoBlocks: version: 3.1.8, author: GoDaddy, Auto-updates enabled
Envato Market: version: 2.0.11, author: Envato, Auto-updates disabled
Gutenberg: version: 18.1.1, author: Gutenberg Team, Updates managed by Host
Jetpack: version: 13.4-a.3, author: Automattic, Updates managed by Host
Jetpack Boost: version: 3.2.2, author: Automattic - Jetpack Site Speed team, Auto-updates enabled
Jetpack Protect: version: 2.1.0, author: Automattic - Jetpack Security team, Auto-updates enabled
Parse.ly: version: 3.14.3, author: Parse.ly, Auto-updates enabled
Redirection: version: 5.4.2, author: John Godley, Auto-updates enabled
Simple Podcasting: version: 1.8.0, author: 10up, Auto-updates enabled
Site Kit by Google: version: 1.124.0, author: Google, Auto-updates enabled
Yoast SEO: version: 22.5, author: Team Yoast, Auto-updates enabled
Yoast SEO Premium: version: 22.2, author: Team Yoast, Auto-updates enabled
Zeen Engine: version: 2.9.1, author: Codetipi, Auto-updates disabled

wp-plugins-inactive (10)

Let's Info Up: version: 1.3.5, author: Codetipi, Auto-updates disabled
Let's Live Blog: version: 1.1.1, author: Codetipi, Auto-updates disabled
Let's Review: version: 3.2.8, author: Codetipi, Auto-updates disabled
Let's Social Count: version: 1.1.7, author: Codetipi, Auto-updates disabled
MC4WP: Mailchimp for WordPress: version: 4.9.11, author: ibericode, Auto-updates disabled
Web Stories: version: 1.36.0, author: Google, Auto-updates enabled
WooCommerce: version: 8.8.2, author: Automattic, Updates managed by Host
WordPress Importer: version: 0.8.2, author: wordpressdotorg, Auto-updates disabled
wp-Typography: version: 5.9.1, author: Peter Putzer, Auto-updates disabled
WP Mapbox GL JS Maps: version: 3.0.1, author: Mapster Tech, Auto-updates disabled

wp-media

image_editor: WP_Image_Editor_GD
imagick_module_version: Not available
imagemagick_version: Not available
imagick_version: Not available
file_uploads: 1
post_max_size: 2047M
upload_max_filesize: 2047M
max_effective_size: 2 GB
max_file_uploads: 20
gd_version: bundled (2.1.0 compatible)
gd_formats: GIF, JPEG, PNG, WebP, BMP, AVIF
ghostscript_version: not available

wp-server

server_architecture: Linux 5.10.0-18-amd64 x86_64
httpd_software: nginx
php_version: 8.3.6 64bit
php_sapi: fpm-fcgi
max_input_variables: 6144
time_limit: 1200
memory_limit: 512M
max_input_time: 1200
upload_max_filesize: 2047M
php_post_max_size: 2047M
curl_version: 8.7.1 OpenSSL/1.1.1w
suhosin: false
imagick_availability: false
pretty_permalinks: true
current: 2024-04-18T01:33:59+00:00
utc-time: Thursday, 18-Apr-24 01:33:59 UTC
server-time: 2024-04-17T21:33:58-04:00

wp-database

extension: mysqli
server_version: 10.4.26-MariaDB-log
client_version: mysqlnd 8.3.6
max_allowed_packet: 104857600
max_connections: 500

wp-constants

WP_HOME: https://americanfieldtrip.com
WP_SITEURL: https://americanfieldtrip.com
WP_CONTENT_DIR: /srv/htdocs/wp-content
WP_PLUGIN_DIR: /srv/htdocs/wp-content/plugins
WP_MEMORY_LIMIT: 512M
WP_MAX_MEMORY_LIMIT: 512M
WP_DEBUG: false
WP_DEBUG_DISPLAY: false
WP_DEBUG_LOG: false
SCRIPT_DEBUG: false
WP_CACHE: true
CONCATENATE_SCRIPTS: undefined
COMPRESS_SCRIPTS: undefined
COMPRESS_CSS: undefined
WP_ENVIRONMENT_TYPE: Undefined
WP_DEVELOPMENT_MODE: undefined
DB_CHARSET: utf8mb4
DB_COLLATE: utf8mb4_unicode_ci

wp-filesystem

wordpress: not writable
wp-content: writable
uploads: writable
plugins: writable
themes: writable
mu-plugins: writable

jetpack

site_id: 154588386
ssl_cert: No
time_diff: undefined
version_option: 13.4-a.3:1713275917
old_version: 13.4-a.1:1712678920
public: Public
master_user: #1 americanfieldtrip
is_offline_mode: off
is_offline_mode_constant: off
current_user: #4 david
tokens_set: Blog User
blog_token: 4vxEb6b*KXvFyaeR040YPo1JM(sz6O4s
user_token: Fn2fuPC1ol9q4NIYq#NbXYtoOXlefEKF
version: 13.4-a.3
jp_plugin_dir: /wordpress/plugins/jetpack/13.4-a.3/
plan: premium
protect_header: {"trusted_header":"REMOTE_ADDR","segments":1,"reverse":false}
full_sync: {"started":"Thu, 01 Jan 1970 00:00:00 +0000","finished":"Thu, 01 Jan 1970 00:00:00 +0000","progress":[],"config":[]}
sync_size: undefined
sync_lag: 0 seconds
full_sync_size: undefined
full_sync_lag: 0 seconds
idc_urls: {"home":"https://americanfieldtrip.com","siteurl":"https://americanfieldtrip.com","WP_HOME":"https://americanfieldtrip.com","WP_SITEURL":"https://americanfieldtrip.com"}
idc_error_option: false
idc_optin: true
cxn_tests: All Pass.

google-site-kit

version: 1.124.0
php_version: 8.3.6
wp_version: 6.5.2
reference_url: https://americanfieldtrip.com
amp_mode: no
site_status: connected-site
user_status: authenticated
verification_status: verified-non-site-kit
connected_user_count: 1
active_modules: site-verification, search-console, adsense, analytics-4, pagespeed-insights
recoverable_modules: none
required_scopes:
openid: ✅
https://www.googleapis.com/auth/userinfo.profile: ✅
https://www.googleapis.com/auth/userinfo.email: ✅
https://www.googleapis.com/auth/siteverification: ✅
https://www.googleapis.com/auth/webmasters: ✅
https://www.googleapis.com/auth/adsense.readonly: ✅
https://www.googleapis.com/auth/analytics.readonly: ✅
https://www.googleapis.com/auth/tagmanager.readonly: ✅
capabilities:
googlesitekit_authenticate: ✅
googlesitekit_setup: ✅
googlesitekit_view_posts_insights: ✅
googlesitekit_view_dashboard: ✅
googlesitekit_manage_options: ✅
googlesitekit_update_plugins: ✅
googlesitekit_view_splash: ✅
googlesitekit_view_authenticated_dashboard: ✅
googlesitekit_view_wp_dashboard_widget: ✅
googlesitekit_view_admin_bar_menu: ✅
googlesitekit_view_shared_dashboard: ⭕
googlesitekit_read_shared_module_data::["search-console"]: ⭕
googlesitekit_read_shared_module_data::["analytics-4"]: ⭕
googlesitekit_read_shared_module_data::["pagespeed-insights"]: ⭕
googlesitekit_manage_module_sharing_options::["search-console"]: ⭕
googlesitekit_manage_module_sharing_options::["analytics-4"]: ✅
googlesitekit_manage_module_sharing_options::["pagespeed-insights"]: ✅
googlesitekit_delegate_module_sharing_management::["search-console"]: ⭕
googlesitekit_delegate_module_sharing_management::["analytics-4"]: ✅
googlesitekit_delegate_module_sharing_management::["pagespeed-insights"]: ⭕
enabled_features:
adsModule: ⭕
audienceSegmentation: ⭕
conversionInfra: ⭕
gm3Components: ⭕
search-console_shared_roles: none
search-console_management: owner
analytics-4_shared_roles: none
analytics-4_management: owner
pagespeed-insights_shared_roles: none
pagespeed-insights_management: all_admins
search_console_property: https://americanfieldtrip.com/
adsense_account_id: none
adsense_client_id: none
adsense_account_status: none
adsense_site_status: none
adsense_use_snippet: yes
adsense_web_stories_adunit_id: none
adsense_setup_completed_timestamp: Not available
adsense_abr_use_snippet: no
adsense_abr_use_error_protection_snippet: no
adsense_abr_setup_status: undefined
analytics_4_account_id: 1302•••••
analytics_4_ads_conversion_id: none
analytics_4_property_id: 3848097••
analytics_4_web_data_stream_id: 5438••••••
analytics_4_measurement_id: G-7R••••••••
analytics_4_use_snippet: yes
analytics_4_available_custom_dimensions: none
analytics_4_ads_linked: false
analytics_4_ads_linked_last_synced_at: 1713384766

parsely (17)

apikey: americanfieldtrip.com
content_id_prefix: undefined
use_top_level_cats: false
custom_taxonomy_section: category
cats_as_tags: false
track_authenticated_users: false
lowercase_tags: true
force_https_canonicals: false
track_post_types:
0: post
track_page_types:
0: page
full_metadata_in_non_posts: true
disable_javascript: false
disable_amp: false
meta_type: json_ld
logo: https://americanfieldtrip.com/wp-content/uploads/2020/12/cropped-icon-2.png
disable_autotrack: false
plugin_version: 3.14.3

`

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dabowman dabowman added the type:bug Something isn't working. label Apr 18, 2024
@jeffpaul jeffpaul added this to the 1.8.1 milestone Apr 18, 2024
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Apr 18, 2024
@kirtangajjar kirtangajjar self-assigned this Jun 8, 2024
@kirtangajjar kirtangajjar moved this from To Do to In Progress in Open Source Practice Jun 8, 2024
@kirtangajjar kirtangajjar linked a pull request Jun 9, 2024 that will close this issue
2 tasks
@kirtangajjar kirtangajjar moved this from In Progress to Code Review in Open Source Practice Jun 9, 2024
@dkotter dkotter modified the milestones: 1.8.1, 1.9.0 Aug 21, 2024
@dkotter dkotter modified the milestones: 1.9.0, Future Release Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
Status: Code Review
Development

Successfully merging a pull request may close this issue.

4 participants