Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening in browser even though apps installed #61

Open
rfunke73 opened this issue Sep 10, 2023 · 6 comments
Open

opening in browser even though apps installed #61

rfunke73 opened this issue Sep 10, 2023 · 6 comments
Assignees
Labels
bug Something isn't working investigate The issue requires investigation and currently can't be labeled as bug or feature request certainly

Comments

@rfunke73
Copy link

hi -
when i get notifications, if i click on it, either a talk or nextcloud(files) notification, it attempts to log me in using a browser.. on a talk notification, if i expand it and click on it, it is ok, but not from its initial state (i made sure open in browser was disabled from the settings)... nextcloud client app (files) notifications when clicked always open in a browser...

thank you!!

@0xf104a
Copy link
Owner

0xf104a commented Sep 10, 2023

Hello. Please check that option "Open Talk notifications in browser" is disabled(if it is, please report it here as this is likely to be a bug). Also by default app assumes that if there is no separate logic for processing notification it should be opened in web-browser and this is the reason why "Files" notifications are opened in browser. If you would give me what kind of notifications you receive I can implement the logic for handling them via app.

@0xf104a 0xf104a added the question Further information is requested label Sep 10, 2023
@rfunke73
Copy link
Author

thanks for the quick response..
that toggle is disabled...
notifications are enabled for everything in talk and on the nexcloud client (calls, mentions,chat, file uploads etc)

@0xf104a 0xf104a added bug Something isn't working investigate The issue requires investigation and currently can't be labeled as bug or feature request certainly and removed question Further information is requested labels Sep 10, 2023
@rfunke73
Copy link
Author

couple of other things..
sometimes clicking the notification sends you to the services app which is strange
no badges appear on the apps themselves (talk and client)

@rfunke73
Copy link
Author

in the interest of getting something to work, is there a way to override opening anything in the web browser? we will always have talk and nextcloud client installed alongside services

thanks!

@0xf104a 0xf104a self-assigned this Sep 23, 2023
@0xf104a
Copy link
Owner

0xf104a commented Sep 23, 2023

Sorry for long response. There is a technical possibility being used for this(e.g. talk notifications should open in talk if option to open in webbrowser is disable, see issue #47 if you would like to know why it was decided to open talk notifications in browser), though it is not completely obvious for me which notifications should be opened in web-browser and which ones in app(it is quite obvious that if there is relevant app, e.g. Talk it should be opened via Talk, though not so obvious for othere apps, e.g. for Files app). Probably, I would add ability to customize this behaviour for each separate kind of notification when I would have enough time for this

@thezonemedia
Copy link

well that part works.. the issue is the response for notifications in talk has web urls and they just open the browser from a button that gets generated (view reply) i disabled that on the web app for now by removing it from the notifications code in the custom_apps folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigate The issue requires investigation and currently can't be labeled as bug or feature request certainly
Projects
None yet
Development

No branches or pull requests

3 participants