Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The connection pool cannot create a new connection after asyncio.CancelledError is raised when connecting to the database #254

Open
lky1937 opened this issue Jun 13, 2024 · 2 comments

Comments

@lky1937
Copy link

lky1937 commented Jun 13, 2024

Hi, I use Python 3.8, peewee_async version is v0.10.0, if asyncio.CancelledError exception occurs when connecting to the database, the connection pool can no longer create new connections available (because old connections are not released). I see that the Exception caught in line 741 of the source code is exception instead of BaseException, and I feel that this causes the above problem.

@kalombos
Copy link
Collaborator

kalombos commented Jun 13, 2024

Could you try the latest version ? Connection management has been rewritten. Also have a look at #207 for more information about cancellation.

@lky1937
Copy link
Author

lky1937 commented Jun 13, 2024

Could you try the latest version ? Connection management has been rewritten. Also have a look at #207 for more information about cancellation.

Thank you for your reply, I will try the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants