Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The future of peewee-async & Looking for maintenance #135

Open
rudyryk opened this issue Feb 27, 2020 · 8 comments
Open

The future of peewee-async & Looking for maintenance #135

rudyryk opened this issue Feb 27, 2020 · 8 comments

Comments

@rudyryk
Copy link
Member

rudyryk commented Feb 27, 2020

This project was started to experiment with async ORM interface. Our dev team has been using this in several small to mid-scale projects in production. But actually we didn't have chance to build some large-scale solution for high loads with it. Right now, peewee-async is used in couple of projects in maintenace mode but not developed actively because of no current business needs and tight resources.

So, I'd want to ask the community: Would somebody want to take on/help with the future development and/or maintenance?

In the recent years more good practices in asyncio interfaces were developed. Also, peewee itself is becoming more developed and also changing it's internals, so keeping up will be another challenge.

Not to mention, peewee's author itself recommends just using Gevent :)
http://docs.peewee-orm.com/en/latest/peewee/database.html#async-with-gevent

I'm thinking that peewee-async could be a good fit for some modern async framework. Also seeing the trend to go serverless apps, and ASGI support is possible there https://github.com/erm/mangum

Thoughts?

@kalombos
Copy link
Collaborator

kalombos commented May 21, 2020

Thank you for the project i use it quite often with FastApi i can help you with fixing bugs and posting issues and i do it already but i am not sure about maintenance. If you guide me i can try to contribute in the project by something that you think is importat at the moment. I hope the project will not be dead :(

@PatTheMav
Copy link

@rudyryk Thank you for all your work and absolutely understandable solution you're in.

Given what the Peewee docs state, I can't help but feel that future work might face the issue that it has to struggle with the fact that Peewee is not (and apparently is not supposed) to work/support asyncio in any way (the gevent solution also doesn't feel like it fits e.g. a web application that runs entirely on the event loop).

So as much as it pains me to put in that extra work it seems to make most sense to abandon Peewee and look for another more async-friendly solution based on aiopg.

@kalombos
Copy link
Collaborator

kalombos commented Aug 3, 2021

Hi @rudyryk i'm thinking what if you make me a collaborator for the project on github and pypi? At least i wolud merge some pull requests and probably people from my company would create new ones from patches they have had. What do you think about the idea?

@rudyryk
Copy link
Member Author

rudyryk commented Aug 13, 2021

@kalombos I'm totally for it, will do.

@kalombos
Copy link
Collaborator

kalombos commented Sep 16, 2021

@rudyryk could you make me as a collaborator on pypi? I have added github CI and merged a bugfix for the project and i am going to merge another bugfix and upload the first own release :)

@rudyryk
Copy link
Member Author

rudyryk commented Oct 8, 2021

@kalombos sorry for the long response, check the invite

@rudyryk
Copy link
Member Author

rudyryk commented Oct 8, 2021

@kalombos I'm also thinking of publishing to PyPi via Github Workflows, should not be a problem

@kalombos
Copy link
Collaborator

kalombos commented Oct 9, 2021

@rudyryk thank you. Yeah, I have come to the same thought to setup continuous delivery to PyPi via Github Workflows and saw an example of a config. I am going to handle with it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants